WESTMIDLANDS|MAY-2025|SARA TAHIR|Sprint 2/coursework #565
+4,657
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 17, 2025
| module.exports = createLookup; | ||
|
|
||
| /*const pair = [['US','USD'],['CA','CAD']] |
There was a problem hiding this comment.
This isn't a major problem here, but remember in a more complex git project not to commit lots of comments of unused code like this.
There was a problem hiding this comment.
Noted, I will make sure I dont make it a practice.
Sprint-2/implement/querystring.js
Outdated
| if (queryString.startsWith("?")) { // Remove "?" if present at start | ||
| queryString = queryString.substring(1); | ||
| } | ||
|
|
||
| if (queryString.length === 0) { |
There was a problem hiding this comment.
Given you are checking for empty strings in the later for loop, do you need to also check for an empty string here?
There was a problem hiding this comment.
Made the change. You are right, The code would have worked just fine as I am checking again for empty strings later.
LonMcGregor
added
Reviewed
|
Great work on this. You can close this sprint now. |
LonMcGregor
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Updated all functions to meet criteria
Wrote tests to see if functions are working correctly
All tests are passing.
Questions
Ask any questions you have for your reviewer.